Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.5] Fix TF examples #3038

Merged
merged 6 commits into from
Oct 15, 2024
Merged

Conversation

YuanTingHsieh
Copy link
Collaborator

Some descriptions are wrong and some scripts have typos.

Description

Fix TF examples README and scripts.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Quick tests passed locally by running ./runtest.sh.
  • In-line docstrings updated.
  • Documentation updated.

nvkevlu
nvkevlu previously approved these changes Oct 14, 2024
Copy link
Collaborator

@nvkevlu nvkevlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these fixes, LGTM

@YuanTingHsieh YuanTingHsieh requested a review from nvkevlu October 14, 2024 22:44
@YuanTingHsieh
Copy link
Collaborator Author

/build

@YuanTingHsieh YuanTingHsieh added documentation Improvements or additions to documentation examples Label for all example related work labels Oct 14, 2024
@YuanTingHsieh
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA enabled auto-merge (squash) October 14, 2024 23:08
@YuanTingHsieh
Copy link
Collaborator Author

/build

@IsaacYangSLA IsaacYangSLA merged commit 773f7f5 into NVIDIA:2.5 Oct 15, 2024
20 checks passed
@YuanTingHsieh YuanTingHsieh deleted the fix_tf_examples_25 branch October 15, 2024 16:45
YuanTingHsieh added a commit to YuanTingHsieh/NVFlare that referenced this pull request Nov 27, 2024
* Fix TF examples

* Fix link

* Update some texts

* Undo changes
YuanTingHsieh added a commit that referenced this pull request Nov 28, 2024
* Fix TF examples

* Fix link

* Update some texts

* Undo changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation examples Label for all example related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants